Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc/example for ref assemblies, PDB and resources #40735

Merged
merged 10 commits into from
May 14, 2024
Merged

Add doc/example for ref assemblies, PDB and resources #40735

merged 10 commits into from
May 14, 2024

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented May 3, 2024 •
edited by github-actions bot
Loading

@buyaa-n buyaa-n requested review from jkotas and gewarren May 3, 2024 01:34
@buyaa-n buyaa-n requested a review from a team as a code owner May 3, 2024 01:34
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 3, 2024
jkotas
jkotas approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
gewarren
gewarren reviewed May 8, 2024
View reviewed changes
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md Outdated Show resolved Hide resolved
@buyaa-n buyaa-n requested a review from gewarren May 11, 2024 01:44
gewarren
gewarren approved these changes May 14, 2024
View reviewed changes
docs/fundamentals/toc.yml Outdated Show resolved Hide resolved
docs/core/porting/net-framework-tech-unavailable.md Outdated Show resolved Hide resolved
docs/core/porting/net-framework-tech-unavailable.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder.md Outdated Show resolved Hide resolved
@buyaa-n @gewarren
Apply suggestions from code review
56029a0 
Co-authored-by: Genevieve Warren <[email protected]>
@buyaa-n buyaa-n enabled auto-merge (squash) May 14, 2024 22:39
@buyaa-n buyaa-n merged commit db4f806 into dotnet:main May 14, 2024
8 checks passed
@buyaa-n buyaa-n deleted the update-ab branch May 14, 2024 22:40
@buyaa-n buyaa-n mentioned this pull request May 15, 2024
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

@gewarren gewarren gewarren approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

@steveharter steveharter Awaiting requested review from steveharter

@ericstj ericstj Awaiting requested review from ericstj

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

Use another Core Assembly with PersistedAssemblyBuilder
4 participants
@buyaa-n @jkotas @gewarren @dotnet-bot